fix: Entity::normalizeValue() must handle UnitEnum before toArray() #10137
Open
maniaba wants to merge 1 commit intocodeigniter4:developfrom
Open
fix: Entity::normalizeValue() must handle UnitEnum before toArray() #10137maniaba wants to merge 1 commit intocodeigniter4:developfrom
maniaba wants to merge 1 commit intocodeigniter4:developfrom
Conversation
Contributor
|
You need to add this fix in v4.7.3 changelog |
michalsn
reviewed
Apr 24, 2026
|
👋 Hi, @maniaba! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
UnitEnuminstanceof check beforeJsonSerializableandmethod_exists($data, 'toArray')in Entity::normalizeValue(), so that enums implementing toArray() are always normalized as enums rather than as generic objects.Fixes #10136
toRawArray() returns raw $this->attributes, so an injected enum object stays as an enum object — not the backing string value. The real regression is that hasChanged() must return false (normalizeValue() handles UnitEnum before toArray()).
Checklist: